Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to list trusted apps #1603

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: allow to list trusted apps #1603

merged 1 commit into from
Apr 22, 2024

Conversation

Maximilien-R
Copy link
Contributor

Currently, the way Lighthouse work doesn't allow us to automatically trigger PRs pipelines when the PR is created by a Github App.

This behaviour is related to the fact that Lighthouse trigger pipelines only for trusted PRs authors. Trusted authors being either the collaborators of the repository or the members of the organization. However, Github apps can't be in any of these cases.

In order to allow Github Apps to be considered as trusted authors, I suggest adding a new configuration option for the Trigger plugin to list authorized applications.

Note: this is a copy of the implementation made in prow.

@jenkins-x-bot
Copy link
Contributor

Hi @Maximilien-R. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@msvticket
Copy link
Member

/ok-to-test

@msvticket
Copy link
Member

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 7f01ff7 into jenkins-x:main Apr 22, 2024
4 checks passed
@Maximilien-R Maximilien-R deleted the feat/allow-trusted-apps branch April 22, 2024 13:55
@Maximilien-R Maximilien-R mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maximilien-R @jenkins-x-bot @msvticket